Re: [PATCH v2 2/3] ARM: dts: exynos: Add clean name of compatible.

[Hoegeun Kwon]

On 09/07/2017 08:27 PM, Marek Szyprowski wrote:
> Hi Hoegeun,
>
> On 2017-09-07 11:39, Hoegeun Kwon wrote:
> > Exynos 5250 and 5420 have different hardware rotation limits. However,
> > currently it uses only one compatible - "exynos5-gsc". Since we have
> > to distinguish between these two, we add different compatible.
> >
> > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>
>
> The new values (5250/5420 specific) should replace old exynos5-gsc, 
> there is no
> point providing both in dts.

Hi Marek,

Thanks for your review.

I used both compatibles to not modify v4l2.
But v4l2 will also be fixed, so 'exynos5-gsc' will be removed.

And also, Thanks for your comment for of_device_get_match_data() of 
patch(3/3).

Best regards,
Hoegeun

> > ---
> >   arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
> >   arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
> > b/arch/arm/boot/dts/exynos5250.dtsi
> > index 8dbeb87..f795c76 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -637,7 +637,7 @@
> >           };
> >             gsc_0:  gsc@13e00000 {
> > -            compatible = "samsung,exynos5-gsc";
> > +            compatible = "samsung,exynos5-gsc", 
> > samsung,exynos5250-gsc";
> >               reg = <0x13e00000 0x1000>;
> >               interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> >               power-domains = <&pd_gsc>;
> > @@ -647,7 +647,7 @@
> >           };
> >             gsc_1:  gsc@13e10000 {
> > -            compatible = "samsung,exynos5-gsc";
> > +            compatible = "samsung,exynos5-gsc", 
> > samsung,exynos5250-gsc";
> >               reg = <0x13e10000 0x1000>;
> >               interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> >               power-domains = <&pd_gsc>;
> > @@ -657,7 +657,7 @@
> >           };
> >             gsc_2:  gsc@13e20000 {
> > -            compatible = "samsung,exynos5-gsc";
> > +            compatible = "samsung,exynos5-gsc", 
> > samsung,exynos5250-gsc";
> >               reg = <0x13e20000 0x1000>;
> >               interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> >               power-domains = <&pd_gsc>;
> > @@ -667,7 +667,7 @@
> >           };
> >             gsc_3:  gsc@13e30000 {
> > -            compatible = "samsung,exynos5-gsc";
> > +            compatible = "samsung,exynos5-gsc", 
> > samsung,exynos5250-gsc";
> >               reg = <0x13e30000 0x1000>;
> >               interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> >               power-domains = <&pd_gsc>;
> > diff --git a/arch/arm/boot/dts/exynos5420.dtsi 
> > b/arch/arm/boot/dts/exynos5420.dtsi
> > index 02d2f89..86afe77 100644
> > --- a/arch/arm/boot/dts/exynos5420.dtsi
> > +++ b/arch/arm/boot/dts/exynos5420.dtsi
> > @@ -658,7 +658,7 @@
> >           };
> >             gsc_0: video-scaler@13e00000 {
> > -            compatible = "samsung,exynos5-gsc";
> > +            compatible = "samsung,exynos5-gsc", 
> > "samsung,exynos5420-gsc";
> >               reg = <0x13e00000 0x1000>;
> >               interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> >               clocks = <&clock CLK_GSCL0>;
> > @@ -668,7 +668,7 @@
> >           };
> >             gsc_1: video-scaler@13e10000 {
> > -            compatible = "samsung,exynos5-gsc";
> > +            compatible = "samsung,exynos5-gsc", 
> > "samsung,exynos5420-gsc";
> >               reg = <0x13e10000 0x1000>;
> >               interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> >               clocks = <&clock CLK_GSCL1>;
>
> Best regards