Re: [PATCH 1/4] sched/sched.h: remove duplicate prototype of __dl_clear_params()

From: Daniel Bristot de Oliveira
Date: Fri Sep 08 2017 - 04:34:04 EST


Hi,

I wonder if a commit log, even an one line comment, explaining that this
function was already declared in the file could help to understand this
patch...

But, the patch is so trivial... that... not sure it is worth... anyway...

On 09/07/2017 12:09 PM, luca abeni wrote:
> Signed-off-by: luca abeni <luca.abeni@xxxxxxxxxxxxxxx>

Reviewed-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>

-- Daniel

> ---
> kernel/sched/sched.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 1043c8b..0b93e4b 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -255,7 +255,6 @@ extern int sched_dl_overflow(struct task_struct *p, int policy,
> extern void __setparam_dl(struct task_struct *p, const struct sched_attr *attr);
> extern void __getparam_dl(struct task_struct *p, struct sched_attr *attr);
> extern bool __checkparam_dl(const struct sched_attr *attr);
> -extern void __dl_clear_params(struct task_struct *p);
> extern bool dl_param_changed(struct task_struct *p, const struct sched_attr *attr);
> extern int dl_task_can_attach(struct task_struct *p,
> const struct cpumask *cs_cpus_allowed);
>