Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors

[Dan Carpenter]

On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 8 Sep 2017, harsha wrote:
> 
> > From: Harsha Sharma <harshasharmaiitr@xxxxxxxxx>
> >
> > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> >
> > Signed-off-by: Harsha Sharma <harshasharmaiitr@xxxxxxxxx>
> > ---
> > Changes in v4:
> >  -Correct the format of the subject.
> >  -Signed-off properly.
> 
> It's not signed off properly.  Like Greg just said (maybe the mails
> crossed), the sign off needs to be the same as the From line.  This
> probably relates to your git configuration or your mailer.  Send the patch
> to yourself before sending it out on the mailing list to be sure that
> everything is ok.
> 

This is actually OK-ish...  It's better when we don't have the extra
From: and there is no need for that with gmail, but we sometimes allow
it for companies which have broken mailservers.

regards,
dan carpenter