[PATCH 4.13 18/47] driver core: bus: Fix a potential double free

From: Greg Kroah-Hartman
Date: Fri Sep 08 2017 - 09:20:30 EST

4.13-stable review patch. If anyone has any objections, please let me know.


From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb upstream.

The .release function of driver_ktype is 'driver_release()'.
This function frees the container_of this kobject.

So, this memory must not be freed explicitly in the error handling path of
'bus_add_driver()'. Otherwise a double free will occur.

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/base/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -698,7 +698,7 @@ int bus_add_driver(struct device_driver

- kfree(drv->p);
+ /* drv->p is freed in driver_release() */
drv->p = NULL;