Re: [PATCH 0/2] Two cleanups for Sphinx conf.py
From: Jonathan Corbet
Date: Fri Sep 08 2017 - 12:10:32 EST
On Sun, 3 Sep 2017 16:12:44 -0300
Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> wrote:
> Those patches are just cleanups for Documentation/conf.py.
>
> The first one removes a package usage directive for a LateX package
> that it is not used.
>
> The second one moves some LaTeX preamble code that it is used only
> on Sphinx 1.4 and 1.5 to a separate if. On Sphinx 1.6, the macros there
> are silently ignored. While the conf.py becomes a little bit more complex,
> it clearly marks the backward-compatible code, with IMHO, it is a
> good idea, specially as some day, we may drop support for older Sphinx
> versions.
>
> None of those patches are mandatory. Feel free to apply any time you
> want (or discard them, if you don't thing it is worth).
OK, these are applied (and the adjustbox one too).
PDF generation seems to work pretty well at the moment, with one
exception: I don't get a table of contents in any of the files (just a
blank page saying "Contents"). Are you seeing something different?
Thanks,
jon