Re: [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421

From: H. Nikolaus Schaller
Date: Fri Sep 08 2017 - 13:44:09 EST



> Am 08.09.2017 um 19:40 schrieb Pali RohÃr <pali.rohar@xxxxxxxxx>:
>
> On Friday 08 September 2017 19:38:37 H. Nikolaus Schaller wrote:
>> and here is the result:
>>
>>> root@letux:~# dmesg|fgrep bq27
>>> [ 10.391235] bq27xxx_battery_setup
>>> [ 10.391265] bq27xxx_battery_setup: dm_regs=bf0520e0
>>> [ 10.393798] (NULL device *): hwmon: 'bq27500-1-0' is not a valid name attribute, please fix
>
> Hi! IIRC hwmon name cannot contain '-'. Use '_' instead.

Yes. I'd like to see it fixed as well...

AFAIR it is a general problem outside of battery drivers and IMHO there is some note somewhere.
Nobody "uses" a '-'. It is some logic that automatically creates node names which hwmon rejects.

BR,
Nikolaus