Re: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support.

[Fabio Estevam]

On Sat, Sep 9, 2017 at 6:28 AM, Wig C <onlywig@xxxxxxxxx> wrote:

> +&usdhc2 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_usdhc2>;
> +       bus-width = <4>;
> +       vmmc-supply = <&wlan_en_reg>;
> +       no-1-8-v;
> +       keep-power-in-suspend;
> +  non-removable;
> +  cap-power-off-card;

As I mentioned previously the indentation is not correct here.

You should use tab instead of spaces.

checkpatch also complains about it:

WARNING: please, no spaces at the start of a line
#699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654:
+  non-removable;$

WARNING: please, no spaces at the start of a line
#700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655:
+  cap-power-off-card;$

> +&wdog1 {
> +       status = "okay";
> +};

Why don't you use like this as you intended in the original patch?

&wdog1 {
    pinctrl-names = "default";
    pinctrl-0 = <&pinctrl_wdog>;
    fsl,ext-reset-output;
    status = "okay";
};