Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos
From: Guenter Roeck
Date: Sat Sep 09 2017 - 10:01:20 EST
On Sat, Sep 09, 2017 at 11:48:48AM +0300, Dan Carpenter wrote:
> On Fri, Sep 08, 2017 at 10:43:40AM -0700, Badhri Jagan Sridharan wrote:
> > >> /*
> > >> - * Select the source PDO providing the most power while staying within
> > >> - * the board's voltage limits. Prefer PDO providing exp
> > >> + * Select the source PDO providing the most power which has a
> > >> + * matchig sink cap. Prefer PDO providing exp
> > > ^^^^^^^ ^^^^^^^^^^^^^
> > > "matching". What does "providing exp" mean?
> >
> > Actually that was moved forward from the existing code.
> > So not sure what that means ? I can remove it, if needed.
> >
>
> If I can't understand it, it probably means that I don't have any
> background knowledge, but if you can't understand it then probably no
> one can. :P Feel free to delete.
>
Agreed. I don't recall what it means either ;-). Most likely something
got lost.
Guenter