Re: [PATCH] sysrq : fix Show Regs call trace on ARM

From: Jibin Xu
Date: Mon Sep 11 2017 - 05:54:59 EST


Hi,Jiri:

get_irq_regs() in the softirq context return NULL.

thanks,
Jibin Xu

On 2017å09æ11æ 13:24, Jiri Slaby wrote:
On 09/11/2017, 05:11 AM, Jibin Xu wrote:
...
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -245,8 +245,10 @@ static void sysrq_handle_showallcpus(int key)
* architecture has no support for it:
*/
if (!trigger_all_cpu_backtrace()) {
- struct pt_regs *regs = get_irq_regs();
+ struct pt_regs *regs = NULL;
+ if (in_irq())
+ regs = get_irq_regs();
Maybe a stupid question: how does get_irq_regs() behave in the softirq
context? I.e. what about s/in_irq/in_interrupt/?

thanks,