Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

From: Benson Leung
Date: Mon Sep 11 2017 - 16:03:03 EST

Hi Oliver,

On Sat, Sep 09, 2017 at 09:35:52AM +0200, Oliver Neukum wrote:
> Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov:
> > From: Benson Leung <bleung@xxxxxxxxxxxx>
> >
> > usbhid->intf->needs_remote_wakeup is set when a device is opened, and is
> > cleared when a device is closed.
> >
> > In usbhid_open, usb_autopm_get_interface is called before setting the
> > needs_remote_wakeup flag, and usb_autopm_put_interface is called after
> > hid_start_in. However, when the device is closed in usbhid_close, we
> > simply reset the flag and the device stays awake even though it could be
> > suspended.
> Hi,
> but if the device is asleep, we do not want to wake it just to reset
> the flag. Please use the no resume varieties. They did not exist when this
> code was written and that is the reason behind the current code.

Thanks for the pointer. I'll respin the patch with the no_resume version of
usb_autopm_get_interface and retest.


Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
Chromium OS Project

Attachment: signature.asc
Description: Digital signature