Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object code size

From: Masahiro Yamada
Date: Tue Sep 12 2017 - 09:34:47 EST


2017-09-12 20:21 GMT+09:00 Colin King <colin.king@xxxxxxxxxxxxx>:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate const arrays on the stack, instead make them
> static. Makes the object code smaller nearly 1000 bytes. Also
> line break wide lines to avoid checkpatch warnings.
>
> Before:
> text data bss dec hex filename
> 13112 1996 0 15108 3b04 pinctrl-uniphier-core.o
>
> After:
> text data bss dec hex filename
> 11642 2476 0 14118 3726 pinctrl-uniphier-core.o
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>


Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>


Thanks!

--
Best Regards
Masahiro Yamada