Re: [PATCH 3/4] xen: add grant interface version dependent constants to gnttab_ops

From: Boris Ostrovsky
Date: Tue Sep 12 2017 - 12:03:18 EST


On 09/08/2017 10:48 AM, Juergen Gross wrote:
> Instead of having multiple variables with constants like
> grant_table_version or grefs_per_grant_frame add those to struct
> gnttab_ops and access them just via the gnttab_interface pointer.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>


One possible suggestion --- define gnttab_sframes() inline and get rid
of RPP/SPP.

But either way:
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

-boris