Re: [PATCH v6] livepatch: introduce shadow variable API

[Josh Poimboeuf]

On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> +		       size_t size, gfp_t gfp_flags, bool warn_on_exist)
> +{
> +	struct klp_shadow *new_shadow;
> +	void *shadow_data;
> +	unsigned long flags;
> +
> +	/* Check if the shadow variable if <obj, id> already exists */

Grammar fix: either

  s/if the shadow variable//

or

  s/if <obj, id>//

Otherwise:

Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

-- 
Josh