Re: [PATCH 2/2] zram: remove zlib from the list of recommended algorithms

From: Sergey Senozhatsky
Date: Wed Sep 13 2017 - 03:16:54 EST


On (09/13/17 16:12), Minchan Kim wrote:
> On Tue, Sep 12, 2017 at 02:00:05PM +0900, Sergey Senozhatsky wrote:
> > ZSTD tends to outperform deflate/inflate, thus we remove
> > zlib from the list of recommended algorithms and recommend
> > zstd instead.
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> > Suggested-by: Minchan Kim <minchan@xxxxxxxxxx>
>
> I did test with my sample data and compared zstd with deflate.
> zstd's compress ratio is lower a little bit but compression
> speed is much faster 3 times more and decompress speed is too
> 2 times more. With different data, it is different but overall,
> zstd would be better for speed at the cost of a little lower compress
> ratio(about 5%) so I believe it's worth to replace deflate.

hm, interesting. on my "real world" use-cases zstd has better
compression ratio.

> Thanks for the patch, Sergey.
>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

thanks.

-ss