Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

[Hoegeun Kwon]

On 09/13/2017 06:11 PM, Sylwester Nawrocki wrote:
> Hi Hoegeun,
>
> On 09/13/2017 04:33 AM, Hoegeun Kwon wrote:
> > > > @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq,
> > > > void *priv)
> > > >       static const struct of_device_id exynos_gsc_match[] = {
> > > >         {
> > > > -        .compatible = "samsung,exynos5-gsc",
> > > > -        .data = &gsc_v_100_drvdata,
> > > Can you keep the "samsung,exynos5-gsc" entry with the gsc_v_5250_variant
> > > data, so that it can work with "samsung,exynos5-gsc" compatible in DT
> > > on both exynos5250 and exynos5420 SoCs?
> > Thank you for your question.
> >
> > Exynos 5250 and 5420 have different hardware rotation limits.
> > Exynos 5250 is '.real_rot_en_w/h = 2016' and 5420 is '.real_rot_en_w/h =
> > 2048'.
> >
> > So my opinion they must have different compatible.
> I think there is some misunderstanding, mu suggestion was to keep the
> "samsung,exynos5-gsc" compatible entry in addition to the new introduced
> ones: "samsung,exynos5250-gsc" and "samsung,exynos5420-gsc". That's in
> order to make your changes possibly backward compatible, in theory
> the updated driver should still work without changes in dts.


Thank you again for your explanation.

Yes, I understood.
I will keep "samsung,exynos5-gsc" compatible,
and add Exynos 5250/5420/5433 compatible.

Best regards,
Hoegeun