Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error

From: Baicar, Tyler
Date: Wed Sep 13 2017 - 10:40:53 EST


On 8/29/2017 2:16 AM, Borislav Petkov wrote:
On Mon, Aug 28, 2017 at 10:53:41AM -0600, Tyler Baicar wrote:
Currently we acknowledge errors before clearing the error status.
This could cause a new error to be populated by firmware in-between
the error acknowledgment and the error status clearing which would
cause the second error's status to be cleared without being handled.
So, clear the error status before acknowledging the errors.

Also, make sure to acknowledge the error if the error status read
fails.

V3: Seperate check for -ENOENT return value

V2: Only send error ack if there was an error populated
Remove curly braces that are no longer needed

Signed-off-by: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx>
---
drivers/acpi/apei/ghes.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Borislav Petkov <bp@xxxxxxx>
Hello Rafael,

Were you able to apply this patch?

Thanks,
Tyler

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.