Re: [PATCH 4.13 20/27] Revert "firmware: add sanity check on shutdown/suspend"
From: Linus Torvalds
Date: Wed Sep 13 2017 - 15:30:51 EST
On Wed, Sep 13, 2017 at 11:38 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
>> Commit 06a45a93e7d34a seems to be a cleanup. The arguments in
>> 06a45a93e7d3 ("firmware: move umh try locks into the umh code") seem
>> valid, and there's no real reason to worry about that FW_OPT_NOWAIT
>> etc for the direct-from-filesystem loading. That's simply not
> Indeed! That stupid UMH lock *seems* wrong on the direct filesystem path!
> Hence these changes.
> The devil is in the details though. That UMH lock however carried an implicit
> suspend guard, the "cleanup" actually then has a functional change. The commit
> which was reverted provided the safe guard in generic form, in case we already
> had become dependent on the suspend guard. This UMH lock on the direct FS path
> then added an implicit "arbitrary rule", as you put it, on the firmware API.
I still refuse to revert a commit "just because".
It improved the code.
There is no actual sign that it causes problems.
Yes, moving the lock may change behavior, but nothing you say actually
makes me think it regressed anything.
I refuse to do this "let's just go back to what we used to have,
without an actual _reason_ to go back to it".
The old user-mode-helper crap was crap that had its own totally
separate issues. Even without the problems that we had with incredibly
bad maintainership of the user mode side, the usermode helper had
serious issues with just the fact that user mode itself is disabled by
the suspend/resume process.
So getting rid of the locking that was added for usermode helper ion
the direct file loading path makes a lot of sense.
Just saying that "we tried to re-introduce that locking in another
form, and that was a mistake, and got reverted" is *not* a reason to
then revert the movement.
Yes, the movement of the locking might need to be reverted too - but
only if it actually shows problems.
We should *not* go back to old code "just because".