Re: [RFC PATCH 0/2] autofs: fix autofs_v5_packet dlivery in compat mode

From: Ian Kent
Date: Wed Sep 13 2017 - 20:32:56 EST


On 01/09/17 19:21, Stanislav Kinsburskiy wrote:
> The problem is that in compat mode struct autofs_v5_packet has to have different size
> (i.e. 4 bytes less).

I regret (several times over) my original decision to not make v5 packets
packed ....

I have to say the description of the problem is not all that good.

>
> This is RFC because:
> 1) This issue is hidden, because autofs pipe has O_DIRECT and the rest of the
> epacket is truncated when read.
> 2) X86 arch doesn't have is_compat_task() helper
> 3) It's now clear, what to do if "pgrp" option is specified.

I don't understand what the "pgrp" option has to do with this?

>
> The following series implements...
>
> ---
>
> Stanislav Kinsburskiy (2):
> autofs: set compat flag on sbi when daemon uses 32bit addressation
> autofs: sent 32-bit sized packet for 32-bit process
>
>
> fs/autofs4/autofs_i.h | 3 +++
> fs/autofs4/dev-ioctl.c | 3 +++
> fs/autofs4/inode.c | 4 +++-
> fs/autofs4/waitq.c | 5 +++++
> 4 files changed, 14 insertions(+), 1 deletion(-)
>