Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support

[Shuah Khan]

On 09/08/2017 06:01 AM, Thomas Meyer wrote:
> The multiple_kprobes test case fails to check for KPROBE_EVENT support.
> Add the check to prevent a false test result.
> 
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> ---
>  tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> index 2a1cb9908746..a4fd4c851a5b 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc
> @@ -1,6 +1,8 @@
>  #!/bin/sh
>  # description: Register/unregister many kprobe events
>  
> +[ -f kprobe_events ] || exit_unsupported # this is configurable
> +
>  # ftrace fentry skip size depends on the machine architecture.
>  # Currently HAVE_KPROBES_ON_FTRACE defined on x86 and powerpc64le
>  case `uname -m` in
> 

Hi Steve/Masami,

This patch looks good to me. Adds a check similar to the one one in
tools/testing/selftests/ftrace/test.d/kprobe/functions

If you don't have objections, I will get this into 4.14-rc2 or rc3

thanks,
-- Shuah