Re: [PATCH RFC V2 00/10] perf top optimization
From: Arnaldo Carvalho de Melo
Date: Thu Sep 14 2017 - 17:19:55 EST
Em Wed, Sep 13, 2017 at 12:38:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Sep 13, 2017 at 03:29:44PM +0000, Liang, Kan escreveu:
> > >
> > > Em Sun, Sep 10, 2017 at 07:23:13PM -0700, kan.liang@xxxxxxxxx escreveu:
> > >
> > > So I got the first two patches already merged, and made some comments
> > > about the other patches, please check those,
> > >
> > Thanks for the review Arnaldo.
> > I will take a close look for the comments.
> > For the next version, I only need to include patch 3-10, correct?
> Right, and go from my perf/core branch. The hashtable patch is still not
> there as I am running tests before pushing out, but it should be there
> later today.
So, its at my repo, branch tmp.perf/threads_hashtable
But 'perf trace' is broken, please take a look below:
[root@jouet ~]# gdb -c core
GNU gdb (GDB) Fedora 8.0-20.fc26
Core was generated by `perf trace -e block:block_bio_queue'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x000000000051089a in ?? ()
(gdb) file perf
Reading symbols from perf...done.
#0 0x000000000051089a in ____machine__findnew_thread (machine=0x3dfcab0, threads=0x3dfca78, pid=-1, tid=-1, create=false) at util/machine.c:429
#1 0x0000000000510b49 in machine__find_thread (machine=0x3dfcab0, pid=-1, tid=-1) at util/machine.c:498
#2 0x0000000000483dd0 in trace__set_filter_loop_pids (trace=0x7ffc0d23f880) at builtin-trace.c:2247
#3 0x000000000048438b in trace__run (trace=0x7ffc0d23f880, argc=0, argv=0x7ffc0d242a00) at builtin-trace.c:2385
#4 0x0000000000487219 in cmd_trace (argc=0, argv=0x7ffc0d242a00) at builtin-trace.c:3121
#5 0x00000000004c0b4a in run_builtin (p=0xa75d00 <commands+576>, argc=3, argv=0x7ffc0d242a00) at perf.c:296
#6 0x00000000004c0db7 in handle_internal_command (argc=3, argv=0x7ffc0d242a00) at perf.c:348
#7 0x00000000004c0f09 in run_argv (argcp=0x7ffc0d24285c, argv=0x7ffc0d242850) at perf.c:392
#8 0x00000000004c12d7 in main (argc=3, argv=0x7ffc0d242a00) at perf.c:536