Re: [experimental PATCH] ovl: get rid of d_real()

From: Al Viro
Date: Fri Sep 15 2017 - 10:07:42 EST


On Fri, Sep 15, 2017 at 03:58:05PM +0200, Miklos Szeredi wrote:
> And here's the prototype. Poof, d_real() is gone.
>
> It definitely has got problems, but just maybe it can be made better than the
> current mess. It *does* solve the ro-rw inconsistency for normal reads (not
> mmaps).

... and makes for mind-boggling amount of opening/closing the files on underlying
filesystem. Doing that on sodding ->read_iter() is simply wrong. And you are
using the wrong credentials for those opens, anyway - it should be creds of opener,
not reader.