Re: [PATCH 3/3] ima: use fs method to read integrity data

From: Linus Torvalds
Date: Fri Sep 15 2017 - 14:05:38 EST

On Fri, Sep 15, 2017 at 2:04 AM, Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 2017-09-14 at 22:50 -0700, Linus Torvalds wrote:
>> This is still wrong.
>> (a) there is no explanation for why we need that exclusive lock in the
>> first place
>> Why should a read need exclusive access? You'd think shared is sufficient.
> True, reading a file shouldn't require an exclusive lock. The
> exclusive lock is taken to prevent the file from changing while the
> file hash is being calculated.

That really shouldn't need an exclusive lock either. The whole point
is that you're just reading the file, so a shared lock should be fine.

There may be other *higher* level reasons why the caller then might
want an exclusive lock for other reasons, but that should have nothing
to do with the reading part.

So this is the thing I want explained. Right now there are no
explanations, and the few comments there are about exclusive locking
don't make sense, and don't match the lockdep tests.

So the patch itself may be fine, but the commentary and explanations
are broken and/or missing.