Re: [PATCH v8 10/18] RISC-V: Init and Halt Code
From: Dmitriy Cherkasov
Date: Sat Sep 16 2017 - 02:25:14 EST
On 09/13/2017 11:15 AM, Daniel Lezcano wrote:
All this code must go in the timer side and use the TIMER_OF_DECLARE
macro with the proper wrappers.
Hi, thanks for the feedback.
Agreed. I'll clean this up.
Where is the request_per_cpu_interrupt()?
What is this riscv_timer_interrupt() signature?
This arch defines a separate exception type for local timer interrupts.
Currently the interrupt controller driver checks the trap cause register,
determines that it's a timer, and calls the handler directly. To make this go
through the interrupt subsystem, this driver would need to be reworked.
Where is get_cycles64() ?
This is in asm/timex.h. Should this be split into a separate asm header ala arm64?
The timer driver should be self-contained and not spread across
different places, it is very difficult to review it.
[ ... ]
Agreed, thanks again for reviewing it anyway :)