Re: [PATCH] checkpatch: do not check missing blank line before builtin_*_driver

[Masahiro Yamada]

Hi Joe,

2017-09-18 5:44 GMT+09:00 Joe Perches <joe@xxxxxxxxxxx>:
> On Sun, 2017-09-17 at 23:59 +0900, Masahiro Yamada wrote:
>> checkpatch.pl does not check missing blank line before module_*_driver.
>> I want it to behave likewise for builtin_*_driver.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index dd2c262aebbf..cec896306619 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3103,6 +3103,7 @@ sub process {
>>                     $line =~ /^\+[a-z_]*init/ ||
>>                     $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
>>                     $line =~ /^\+\s*DECLARE/ ||
>> +                   $line =~ /^\+\s*builtin_/ ||
>
> I believe
>
>                       $line =~ /^\+\s*builtin_[\w_]*driver/ ||
>
> would be better


Thanks for your advice.
I've sent v2.


-- 
Best Regards
Masahiro Yamada