Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

From: Greg KH
Date: Mon Sep 18 2017 - 09:59:50 EST


On Sun, Sep 17, 2017 at 08:54:18PM -0700, kys@xxxxxxxxxxxxxxxxxxxxxx wrote:
> From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
>
> This extends existing vmbus related sysfs structure to provide per-channel
> state information. This is useful when diagnosing issues with multiple
> queues in networking and storage.
>
> The existing sysfs only displayed information about the primary
> channel. The one place it reported multiple channels was the
> channel_vp_mapping file which violated the sysfs convention
> of one value per file.
>
> Signed-off-by: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
> Documentation/ABI/stable/sysfs-bus-vmbus | 56 ++++++++++
> drivers/hv/channel_mgmt.c | 10 +-
> drivers/hv/hyperv_vmbus.h | 2 +
> drivers/hv/vmbus_drv.c | 185 +++++++++++++++++++++++++++++--
> include/linux/hyperv.h | 6 +
> 5 files changed, 246 insertions(+), 13 deletions(-)

Feels like a new feature to me, and not needed in 4.14-final.

thanks,

greg k-h