Re: [PATCH v2] s390/char: Fix cdev_add usage

From: Heiko Carstens
Date: Mon Sep 18 2017 - 10:22:54 EST


On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote:
> Function cdev_add does set cdev->dev, so there is no point in setting
> it prior to calling this function.
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> ---
> Untested. Changes since v1 (2016-07-13):
> * Improved description
> * Added a few blank lines to make the code more readable
>
> drivers/s390/char/tape_class.c | 3 +--
> drivers/s390/char/vmlogrdr.c | 4 ++--
> drivers/s390/char/vmur.c | 4 ++--
> 3 files changed, 5 insertions(+), 6 deletions(-)

Applied, however without the extra blank lines ;)
Thanks!