Re: [PATCH v4 1/2] wire: export w1_touch_bit

[GregKH]

On Mon, Sep 18, 2017 at 09:34:27PM +0200, Jan Kandziora wrote:
> Am 18.09.2017 um 16:19 schrieb GregKH:
> > On Mon, Sep 18, 2017 at 03:03:45PM +0200, Jan Kandziora wrote:
> >> The w1_ds28e17 driver from the next part of this patch needs to emit
> >> single-bit read timeslots to the DS28E17. The w1 subsystem already
> >> has this function but it is not exported outside drivers/w1/w1_io.c
> >>
> >> This subpatch exports the w1_touch_bit symbol with EXPORT_SYMBOL_GPL,
> >> same as the other exported symbols in drivers/w1/w1_io.c
> >>
> >> May be also useful later for writing drivers for other Onewire chips
> >> which do single-bit communication.
> >>
> >> Signed-off-by: Jan Kandziora <jjj@xxxxxx>
> >> Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
> >> ---
> >> Changes in v4 against v3 in this subpatch:
> >>   - adapted to linux-4.12.0
> >>
> >> No changes in v3 against v2,v1 in this subpatch.
> > 
> > You should change it as it does not apply to 4.14-rc1 :(
> > 
> Okay, I will review them again.
> 
> 
> > Please rebase your patches and resend them, with Evgeniy's acks added to
> > them.
> > 
> Now you caught me. I don't know how to do that. What's required? The
> Acked-by: line? Am I allowed to simply add these lines to my patches or
> is there a procedure to follow?

Just add the acked-by line, like I did above, and all should be fine.

thanks,

greg k-h