Re: [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS

[Vijay Viswanath]

On 9/14/2017 12:04 PM, Adrian Hunter wrote:
> On 30/08/17 15:51, Vijay Viswanath wrote:
> > Enable CONFIG_MMC_SDHCI_IO_ACCESSORS so that SDHC controller specific
> > register read and write APIs, if registered, can be used.
>
> Missing signed-off
>
> Why don't you put this patch earlier in the patch set and then you don't
> need all the ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS ?

This will involve merging the current patches 3 & 4 into one (Some 
functions defined under ifdef in patch 3 are used only in patch 4). Will 
that be fine ?

> > ---
> >   drivers/mmc/host/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 2db84dd..64a9298 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -420,6 +420,7 @@ config MMC_SDHCI_MSM
> >   	tristate "Qualcomm SDHCI Controller Support"
> >   	depends on ARCH_QCOM || (ARM && COMPILE_TEST)
> >   	depends on MMC_SDHCI_PLTFM
> > +	select CONFIG_MMC_SDHCI_IO_ACCESSORS
>
> CONFIG_MMC_SDHCI_IO_ACCESSORS -> MMC_SDHCI_IO_ACCESSORS
>
> >   	help
> >   	  This selects the Secure Digital Host Controller Interface (SDHCI)
> >   	  support present in Qualcomm SOCs. The controller supports