Re: [PATCH] openrisc: dts: or1ksim: Add stdout-path

[Geert Uytterhoeven]

Hi Stafford,

On Tue, Sep 19, 2017 at 4:00 PM, Stafford Horne <shorne@xxxxxxxxx> wrote:
> During reviews of the OpenRISC SMP patch series it was suggested to add
> stdout-path to the SMP dts file.  Add stdout-path to our other dts files
> to be a good example.
>
> Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
> ---
>  arch/openrisc/boot/dts/or1ksim.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/openrisc/boot/dts/or1ksim.dts b/arch/openrisc/boot/dts/or1ksim.dts
> index 5d4f9027afaf..ecc30968cbcb 100644
> --- a/arch/openrisc/boot/dts/or1ksim.dts
> +++ b/arch/openrisc/boot/dts/or1ksim.dts
> @@ -7,6 +7,7 @@
>
>         chosen {
>                 bootargs = "console=uart,mmio,0x90000000,115200";
> +               stdout-path = &serial0;

I think that should be:

-               bootargs = "console=uart,mmio,0x90000000,115200";
+               stdout-path = "serial0:115200";

If stdout-path is present, it will become the default console.
All other UART parameters except for the serial speed are derived from
the serial0 node (= serial@90000000) in DT.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds