Re: [PATCH 2/2] hwmon: add dt binding for max1619

From: Alan Tull
Date: Tue Sep 19 2017 - 14:12:10 EST


On Mon, Sep 18, 2017 at 4:11 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Mon, Sep 11, 2017 at 12:58:57PM -0700, Guenter Roeck wrote:
>> On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote:
>> > Add new device tree binding for max1619.
>> >
>> > Signed-off-by: Alan Tull <atull@xxxxxxxxxx>
>>
>> Technically that should already work, without explicit binding,
>> or did the i2c core change lately ?
>
> There was some work in that direction IIRC.

Yes, after Guenter replied I tried it without this patch and it
worked. i2c drivers can have a 'detect' function that can check part
id, etc. If detection succeeds, it will fill in the device name in
i2c_board_info->type and the i2c-core will enumerate using that.

Alan

>
> We don't really want to rely on that behavior and should have DT match
> strings.
>
> Rob