Re: [PATCH net-next 0/4] net: dsa: move master ethtool code

From: David Miller
Date: Tue Sep 19 2017 - 19:04:43 EST


From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Tue, 19 Sep 2017 13:04:56 -0700

> On 09/19/2017 08:56 AM, Vivien Didelot wrote:
>> The DSA core overrides the master device's ethtool_ops structure so that
>> it can inject statistics and such of its dedicated switch CPU port.
>>
>> This ethtool code is currently called on unnecessary conditions or
>> before the master interface and its switch CPU port get wired up.
>> This patchset fixes this.
>>
>> Similarly to slave.c where the DSA slave net_device is the entry point
>> of the dsa_slave_* functions, this patchset also isolates the master's
>> ethtool code in a new master.c file, where the DSA master net_device is
>> the entry point of the dsa_master_* functions.
>>
>> This is a first step towards better control of the master device and
>> support for multiple CPU ports.
>
> Tested-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> * ethtool -S eth0 -> switch port CPU stats are still correctly overlayed
> * ethtool -s gphy wol g -> both switch port and CPU port correctly
> enable WoL
> * ethtool -i eth0 -> driver still reports correct information

Series applied, thanks everyone.