Re: [PATCH 1/2] dts: display5: Device tree description of LWN's DISPLAY5 board

[Åukasz Majewski]

On 09/18/2017 06:06 PM, Fabio Estevam wrote:
> Hi Lukasz,
>
> On Mon, Sep 18, 2017 at 11:59 AM, Lukasz Majewski <lukma@xxxxxxx> wrote:
>
> > diff --git a/arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts b/arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > new file mode 100644
> > index 0000000..0160ecf
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts
> > @@ -0,0 +1,24 @@
> > +/*
> > + * Copyright 2017
> > + * Lukasz Majewski, DENX Software Engineering, lukma@xxxxxxx
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
>
> Have you considered using a dual GPL/X11 license? Same apply to the
> other new dts/dtsi files.

Ok. I will provide dual license in v2.

> > +/dts-v1/;
> > +
> > +#include "imx6q-display5.dtsi"
> > +
> > +&panel {
> > +       compatible = "mitsubishi,aa070mc01-ca1";
>
> I don't see this binding accepted in mainline, so it would be better
> to resend it after it reaches mainline.

I did not yet received any reply for this patch.

> > +&ssi2 {
> > +       fsl,mode = "i2s-master";
>
> Please remove this property. simple-audio-card already specifies who is master.

Ok.

> > +       pinctrl_ecspi2_cs: ecspi2csgrp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_CSI0_DAT11__GPIO5_IO29 0x80000000
>
> Please do not use 0x80000000. Use the real IOMUX value instead.

Could you be more specific here?

The 0x80000000 corresponds to IMX_NO_PAD_CTL in pinctrl-imx.c, which 
prevents from manual GPIO control.

The 0x80000000 value is the IOMUXC_SW_PAD_CTL_PAD_CSI0_DATA11 
(0x020E_0654) config data (16 bits only -> 0x0).

Writing 0x0 to this register is perfectly fine for my application.


I'm a bit in doubt to what I shall do more?

> > +               >;
> > +       };
> > +
> > +       pinctrl_ecspi2_flwp: ecspi2flwpgrp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_SD3_DAT5__GPIO7_IO00 0x80000000
>
> Ditto.
>
> > +               >;
> > +       };
> > +
> > +       pinctrl_ecspi3: ecspi3grp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO      0x100b1
> > +                       MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI      0x100b1
> > +                       MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK      0x100b1
> > +               >;
> > +       };
> > +
> > +       pinctrl_ecspi3_cs: ecspi3csgrp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000
>
> Ditto.
>
> > +               >;
> > +       };
> > +
> > +       pinctrl_ecspi3_flwp: ecspi3flwpgrp {
> > +               fsl,pins = <
> > +                       MX6QDL_PAD_DISP0_DAT6__GPIO4_IO27 0x80000000
>
> Ditto.


--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@xxxxxxx