Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf

[Gregory Fong]

On Wed, Sep 20, 2017 at 12:13 AM, Arvind Yadav
<arvind.yadav.cs@xxxxxxxxx> wrote:
> devm_kasprintf() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-brcmstb.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index dd0308c..1227d6e 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
>                 gc->of_node = np;
>                 gc->owner = THIS_MODULE;
>                 gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> +               if (!gc->label)
> +                       goto fail;

Please also set err to -ENOMEM.

> +
>                 gc->base = gpio_base;
>                 gc->of_gpio_n_cells = 2;
>                 gc->of_xlate = brcmstb_gpio_of_xlate;
> --
> 1.9.1
>

Thanks,
Gregory