[PATCH v2] PM / OPP: Use snprintf to avoid kasprintf and kfree

From: Arvind Yadav
Date: Thu Sep 21 2017 - 01:46:45 EST


Use snprintf to avoid unnecessary initializations, avoid calling kfree.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
---
changes in v2:
Remove kasprintf instead of error checking.

drivers/base/power/opp/debugfs.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c
index 81cf120..a2fa785 100644
--- a/drivers/base/power/opp/debugfs.c
+++ b/drivers/base/power/opp/debugfs.c
@@ -41,16 +41,15 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
{
struct dentry *d;
int i;
- char *name;

for (i = 0; i < opp_table->regulator_count; i++) {
- name = kasprintf(GFP_KERNEL, "supply-%d", i);
+ char name[15];
+
+ snprintf(name, sizeof(name), "supply-%d", i);

/* Create per-opp directory */
d = debugfs_create_dir(name, pdentry);

- kfree(name);
-
if (!d)
return false;

--
1.9.1