Re: [PATCH 0/8] pinctrl: meson: clean pin offsets
From: Linus Walleij
Date: Thu Sep 21 2017 - 08:21:26 EST
On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
> The initial goal of this series was move to TEST_N pin from the EE
> controller to AO controller, where it belongs. This meant modify the
> EE_OFF value.
> This offset is a quirk we brought from the vendor driver when it was
> initially merged. There no reason to keep this around and we could simply
> let pinctrl figure the pin base value.
> Removing this offset, while simple, ends up being quite a patch bomb.
> This is why I split the change over 5 first patches, so the important
> change, patch #1 remains visible. Of course, to avoid breaking bisect,
> these first 5 patches should be squashed into one. (If you prefer that I
> squash it myself, I may have to send you a PR as the patch would exceed
> VGER 100000 characters limit)
> The last change is this series, while not directly related, also requires
> to adjust the gpio-line-names property in DT. Having these changes going
> together would make it easier to coordinate the DTS changes.
> This was changeset has been test on gxbb P200, gxl libretech-cc. It was
> also boot tested on meson8 (Thx Martin!)
> Jerome Brunet (8):
> pinctrl: meson: remove offset from pinctrl
> pinctrl: meson: remove offset continued - gxbb
> pinctrl: meson: remove offset continued - gxl
> pinctrl: meson: remove offset continued - meson8
> pinctrl: meson: remove offset continued - meson8b
> pinctrl: meson: get rid of pin_base
> pinctrl: meson-gx: TEST_N belongs to the AO controller
> pinctrl: meson-gxbb: add missing GPIOX_22 pin
Looks good just waiting for review from Carlo && || Kevin.