Re: [PATCH v1 1/6] perf record: Record the first sample time and last sample time to perf file header

[Jiri Olsa]

On Wed, Sep 20, 2017 at 11:12:32PM +0800, Jin Yao wrote:

SNIP

> @@ -2647,11 +2681,22 @@ int perf_file_header__read(struct perf_file_header *header,
>  
>  	if (header->size != sizeof(*header)) {
>  		/* Support the previous format */
> -		if (header->size == offsetof(typeof(*header), adds_features))
> +		if (header->size == offsetof(typeof(*header), adds_features)) {
>  			bitmap_zero(header->adds_features, HEADER_FEAT_BITS);
> -		else
> +			header->first_sample_time = 0;
> +			header->last_sample_time = 0;
> +			format_feature = false;
> +			format_time = false;
> +		} else if (header->size == offsetof(typeof(*header),
> +				first_sample_time)) {
> +			header->first_sample_time = 0;
> +			header->last_sample_time = 0;
> +			format_time = false;
> +		} else

ok, disregard my previou comment.. I should have read the full patch first ;-)

jirka