Re: Query regarding synchronize_sched_expedited and resched_cpu
From: Steven Rostedt
Date: Thu Sep 21 2017 - 11:46:49 EST
On Thu, 21 Sep 2017 15:55:46 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Mon, Sep 18, 2017 at 11:11:05AM -0400, Steven Rostedt wrote:
> > On Sun, 17 Sep 2017 11:37:06 +0530
> > Neeraj Upadhyay <neeraju@xxxxxxxxxxxxxx> wrote:
> >
> > > Hi Paul, how about replacing raw_spin_trylock_irqsave with
> > > raw_spin_lock_irqsave in resched_cpu()? Are there any paths
> > > in RCU code, which depend on trylock check/spinlock recursion?
> >
> > It looks to me that resched_cpu() was added for nohz full sched
> > balancing, but is not longer used by that. The only user is currently
> > RCU. Perhaps we should change that from a trylock to a lock.
>
> No, regular NOHZ balancing. NOHZ FULL wasn't conceived back then.
>
> 46cb4b7c88fa ("sched: dynticks idle load balancing")
Bah, every time I type NOHZ today I add FULL after it. I did mean NOHZ
without FULL. :-p
-- Steve