Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe

From: Kyle Roeschley
Date: Fri Sep 22 2017 - 10:08:17 EST

On Fri, Sep 22, 2017 at 08:47:12AM +0300, Mika Westerberg wrote:
> On Thu, Sep 21, 2017 at 02:20:03PM -0500, Kyle Roeschley wrote:
> > Powering off the system on Apollo Lake does not clear the interrupt
> > enable registers for the GPIOs. To avoid an interrupt storm on driver
> > probe, clear all interrupt enables before enabling our interrupt line.
> It is up to the BIOS to set the proper mask and program the pads
> accordingly. Which platform and BIOS this is?
> I would rather not do this because it might cause other problems.

I haven't seen any issues in testing. This is on a platform based on the Oxbow
Hill CRB, but it's entirely possible that there's a bug in the BIOS power
sequencing behavior. I'll dig around and see if something's been missed.

Kyle Roeschley
Software Engineer
National Instruments