Re: [PATCH] lib: zstd: make const array rtbTable static, reduces object code size

[Colin Ian King]

On 22/09/17 20:14, Nick Terrell wrote:
> On 9/22/17, 8:00 AM, "linux-kernel-owner@xxxxxxxxxxxxxxx on behalf of Colin King" <linux-kernel-owner@xxxxxxxxxxxxxxx on behalf of colin.king@xxxxxxxxxxxxx> wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Don't populate const array rtbTable on the stack, instead make it
>> static. Also split overly long line to clean a chechkpach warning.
>> Makes the object code smaller by nearly 500 bytes:
>>
>> Before:
>>    text	   data	    bss	    dec	    hex	filename
>>   13297	    104	      0	  13401	   3459	lib/zstd/fse_compress.o
>>
>> After:
>>    text	   data	    bss	    dec	    hex	filename
>>   12742	    160	      0	  12902	   3266	lib/zstd/fse_compress.o
>>
>> (gcc 6.3.0, x86-64)
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> I tested your patch with gcc-7.1 on x86, and benchmarked the speed on
> upstream zstd. There isn't a noticeable speed difference, since it isn't a
> particularly hot piece of code. Would you be able to submit the same patch
> upstream [1], or would you be okay with me porting it back upstream, so it
> doesn't get lost on an update?

Since you have more contact with the zstd codebase it may be preferable
for me to pass the port back to upstream over to you Nick (if that's
OK). As it stands, I did a quick check by building the original zstd
codebase with gcc 7.2 and didn't observe any object code size changes
between the original and the patched code. I see that it's optimized
with -O3 and its not using the same gcc flags as the kernel, so I
suspect that may need exploring further to see why there is such a large
change on the kernel version and that of the native user space library
build.

> 
> I didn't expect gcc to leave constant arrays on the stack, that seems
> silly. Clang makes it static, but gcc loads it onto the stack, and in 6.3+
> it saves the data statically, and then uses vector instructions to load it
> onto the stack [2].

Oh, that latter information is interesting, didn't know that.

Thanks for testing.

Colin
> 
> Tested-by: Nick Terrell <terrelln@xxxxxx>
> 
> [1] https://github.com/facebook/zstd
> [2] https://godbolt.org/g/fvTcED
> 
> 
> NïïïïïrïïyïïïbïXïïÇvï^ï)Þ{.nï+ïïïzïÞ6ïïï+ï)ïïïw*jgïïïïïïïïÝj/ïïïzïÞïï2ïÞïïï&ï)ßïaïïïïïGïïïhïïj:+vïïïwïÙ
>