[PATCH 8/8] extcon: gpio: Always check state on resume

From: Linus Walleij
Date: Sun Sep 24 2017 - 11:02:50 EST


It makes most sense to always check the state of the GPIO external
connector at system resume so just do this by default. Add a TODO
if people turn out to desire to parameterize this.

Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
---
drivers/extcon/extcon-gpio.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
index b7353f5018b5..4f0ad5ad2722 100644
--- a/drivers/extcon/extcon-gpio.c
+++ b/drivers/extcon/extcon-gpio.c
@@ -83,6 +83,15 @@ static int gpio_extcon_probe(struct platform_device *pdev)
if (!data)
return -ENOMEM;

+ /*
+ * Always checking connector state on resume makes most sense so do this
+ * by default.
+ *
+ * TODO: if parameterization is needed, augment this to use proper device
+ * properties or set it up from PM core.
+ */
+ data->check_on_resume = true;
+
data->gpiod = devm_gpiod_get(dev, "extcon", GPIOD_IN);
if (IS_ERR(data->gpiod))
return PTR_ERR(data->gpiod);
--
2.13.5