Re: [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall

From: Peter Zijlstra
Date: Mon Sep 25 2017 - 04:36:12 EST


On Sun, Sep 24, 2017 at 10:52:58PM -0300, Marcelo Tosatti wrote:
> On Fri, Sep 22, 2017 at 02:59:51PM +0200, Peter Zijlstra wrote:

> > Your patch is voodoo programming. You don't solve the actual problem,
> > you try and paper over it.
>
> Priority boosting on a particular section of code is voodoo programming?

Yes, because there's nothing that prevents said section of code from
triggering the exact problem you're trying to avoid.

The real fix is making sure the problem cannot happen to begin with,
which is done by fixing the interaction between the VCPU and that
emulation thread thing.