Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new()

From: David Howells
Date: Mon Sep 25 2017 - 10:15:00 EST


Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> Fix this by removing the call to key_revoke(). key_put() is sufficient,
> as it's not possible for an uninstantiated authkey to have been used for
> anything yet.

Note that the owner can call keyctl_describe() upon it, though that shouldn't
wait because KEY_LOOKUP_PARTIAL would be specified.

However, this is probably fair enough, and it should be gc'd quickly because
it'll lose its last ref.

David