Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
From: Randy Dunlap
Date: Mon Sep 25 2017 - 15:31:24 EST
On 09/25/17 12:22, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 09:20:31PM +0200, Geert Uytterhoeven wrote:
>
>> The issue is builtin drivers that depend on a modular API. The clean way
>> is to separate API and implementation, so the API can be builtin, and the
>> implementation can be modular.
>> Hence the API should provide stubs that call into function pointers, to be
>> registered by the module providing the implementation.
>
> In this case the problem is even more basic in that the driver does
> actually depend on having hwspinlocks for any production use.
>
so just add:
depends on HWSPINLOCK
Is that satisfactory to you?
--
~Randy