Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat
From: Al Viro
Date: Mon Sep 25 2017 - 22:00:58 EST
On Tue, Sep 26, 2017 at 02:46:56AM +0100, Al Viro wrote:
> On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
>
> > And I think your recent compat cleanup work actually made it worse,
> > showing new warnings (including the one that was a real bug)
>
> Actually, they are not new - try make C=2 ipc/compat.o on v4.13 and you'll
> see their previous locations.
>
> > Patch to at least fix the address space warnings in ipc/ attached.
>
> Which tree do you prefer it to go through? Direct to mainline, or vfs.git
> #for-next?
FWIW, __percpu and __rcu annotations are messy as hell. Never got around
to sorting down the infrastructure annotations for that bunch, and I'm
not entirely sure that they (especially __rcu) are a good match for
__address_space__(()).