Re: [PATCH 09/25] hrtimer: Reduce conditional code (hrtimer_reprogram())

From: Peter Zijlstra
Date: Tue Sep 26 2017 - 08:08:06 EST


On Thu, Aug 31, 2017 at 12:23:37PM -0000, Anna-Maria Gleixner wrote:
> The hrtimer_reprogram() is currently required only when
> CONFIG_HIGH_RES_TIMERS is set. Additional bitfields of hrtimer_cpu_base
> struct are high resolution timer specific as well.
>
> To simplify the hrtimer code, the behaviour of CONFIG_HIGH_RES_TIMERS and
> !CONFIG_HIGH_RES_TIMERS should be similar. As preparation for this, the
> function hrtimer_reprogram() and required hrtimer_cpu_base struct members
> are moved outside the conditional area.

This Changelog is impenetrable. That is, I've no idea what you're
trying to say.

As to the patch, that makes hrtimer_reprogram exist unconditionally, but
the only callsite (so far) is condition on hrtimer_is_hres_active(),
which can only be true if HIGH_RES.

So what, except grow the image size, does this patch achieve?