Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag

From: Ross Zwisler
Date: Tue Sep 26 2017 - 13:16:45 EST


On Tue, Sep 26, 2017 at 08:36:50AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote:
> > Currently only the blocksize is checked, but we should really be calling
> > bdev_dax_supported() which also tests to make sure we can get a
> > struct dax_device and that the dax_direct_access() path is working.
> >
> > This is the same check that we do for the "-o dax" mount option in
> > xfs_fs_fill_super().
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> I think we just want to pick this up ASAP. And between my vague
> memoried and that reviewed-by tag it already was part of a different
> series, wasn't it?

Yep, the first 2 patches were part of this series:

https://lkml.org/lkml/2017/9/7/552

which you reviewed. I included them in this series because the later patches
needed to build on them. It looks like they are now in Darrick's
xfs-4.14-fixes branch, but haven't yet made it upstream.