Re: [PATCH net] net: dsa: mv88e6xxx: lock mutex when freeing IRQs

From: Vivien Didelot
Date: Tue Sep 26 2017 - 14:04:53 EST


Hi Andrew,

Andrew Lunn <andrew@xxxxxxx> writes:

> In general, i tried to keep the mutex out of the interrupt code. That
> is not totally possible, the IRQ thread handler needs it. But
> otherwise, the IRQ code assumes it is called with the mutex taken.
>
> So i think it is better to hold the mutex in mv88e6xxx_remove() when
> calling mv88e6xxx_g1_irq_free().

I'd prefer that too. Respinning, thanks!


Vivien