Re: [PATCH net-next RFC 0/5] batched tx processing in vhost_net

[Jason Wang]

On 2017å09æ27æ 03:26, Michael S. Tsirkin wrote:
> On Fri, Sep 22, 2017 at 04:02:30PM +0800, Jason Wang wrote:
> > Hi:
> >
> > This series tries to implement basic tx batched processing. This is
> > done by prefetching descriptor indices and update used ring in a
> > batch. This intends to speed up used ring updating and improve the
> > cache utilization. Test shows about ~22% improvement in tx pss.
>
>
>
> > Please review.
> >
> > Jason Wang (5):
> >    vhost: split out ring head fetching logic
> >    vhost: introduce helper to prefetch desc index
> >    vhost: introduce vhost_add_used_idx()
> Please squash these new APIs into where they are used.
> This split-up just makes review harder for me as
> I can't figure out how the new APIs are used.

Ok.

Thanks

> >    vhost_net: rename VHOST_RX_BATCH to VHOST_NET_BATCH
> This is ok as a separate patch.
>
> >    vhost_net: basic tx virtqueue batched processing
> >
> >   drivers/vhost/net.c   | 221 ++++++++++++++++++++++++++++----------------------
> >   drivers/vhost/vhost.c | 165 +++++++++++++++++++++++++++++++------
> >   drivers/vhost/vhost.h |   9 ++
> >   3 files changed, 270 insertions(+), 125 deletions(-)
> >
> > --
> > 2.7.4