Re: [GIT PULL] x86-refcount fix for v4.14-rc3

From: Kees Cook
Date: Wed Sep 27 2017 - 07:47:50 EST


On Wed, Sep 27, 2017 at 12:57 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> Hi,
>>
>> Please pull this x86-refcount fix for v4.14-rc3. This restores the x86
>> fast-refcount protection after fixing a corner case that was found late
>> before the merge window opened. This was the only problem seen during
>> the protection's life in linux-next, so getting this into v4.14 is
>> highly desired.
>
> No, this is clearly v4.15 material.

Given the long bake time in linux-next (with only the one bug), and
that the fix was done weeks ago, why the delay?

>> Kees Cook (2):
>> locking/refcounts, x86/asm: Use unique .text section for refcount exceptions
>> locking/refcounts, x86/asm: Enable CONFIG_ARCH_HAS_REFCOUNT
>
> Do these commits differ from what you sent as patches on Sep 2?

They are the same, but now that we've reached -rc2, there's no longer
the fuzz against the linker script changes, so it seemed like a better
way to send them your way.

-Kees

--
Kees Cook
Pixel Security