Re: [PATCH v4 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes
From: Paolo Bonzini
Date: Thu Sep 28 2017 - 06:57:11 EST
On 27/09/2017 18:06, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 27, 2017 at 02:46:23PM +0100, Joao Martins wrote:
>> This file defines an ABI shared between guest and hypervisor(s)
>> (KVM, Xen) and as such there should be an correspondent entry in
>> MAINTAINERS file. Notice that there's already a text notice at the
>> top of the header file, hence this commit simply enforces it more
>> explicitly and have both peers noticed when such changes happen.
>>
>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
>> Acked-by: Juergen Gross <jgross@xxxxxxxx>
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>> ---
>> In the end, I choose the originally posted because this is so far the
>> only ABI shared between Xen/KVM. Therefore whenever we have more things
>> shared it would deserve its own place in MAINTAINERS file. If the
>> thinking is wrong, I can switch to the alternative with a
>> "PARAVIRT ABIS" section.
>>
>> Changes since v1:
>> * Add Juergen Gross Acked-by.
>> ---
>> MAINTAINERS | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6671f375f7fc..a4834c3c377a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7603,6 +7603,7 @@ S: Supported
>> F: arch/x86/kvm/
>> F: arch/x86/include/uapi/asm/kvm*
>> F: arch/x86/include/asm/kvm*
>> +F: arch/x86/include/asm/pvclock-abi.h
>> F: arch/x86/kernel/kvm.c
>> F: arch/x86/kernel/kvmclock.c
>>
>> @@ -14718,6 +14719,7 @@ F: arch/x86/xen/
>> F: drivers/*/xen-*front.c
>> F: drivers/xen/
>> F: arch/x86/include/asm/xen/
>> +F: arch/x86/include/asm/pvclock-abi.h
>> F: include/xen/
>> F: include/uapi/xen/
>> F: Documentation/ABI/stable/sysfs-hypervisor-xen
>> --
>> 2.11.0
>>